Attention is currently required from: arehbein, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31534 )
Change subject: common: Make socket queue max. length configurable ...................................................................... Patch Set 6: Code-Review-1 (3 comments) File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/31534/comment/d278fbc8_0920d1d7 PS6, Line 993: bts->pcu.sock_wqueue_len_max < 1 No need to check the value range here, libosmovty ensures that it's in the specified range. File tests/osmo-bts.vty: https://gerrit.osmocom.org/c/osmo-bts/+/31534/comment/c0965990_769efff5 PS6, Line 228: help The libosmovty's own command are intentionally masked with '...', please keep it this way. It's done on purpose to avoid failures when someone adds new commands to libraries. https://gerrit.osmocom.org/c/osmo-bts/+/31534/comment/741652de_e4c5bb10 PS6, Line 271: help Description of the interactive help system : list Print command list : show Show running system information : write Write running configuration to memory, network, or terminal : exit Exit current mode and down to previous mode : Same here, these commands are masked with '...' on purpose. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id6ba6e4eadce9ce82ef2407f4e28346e7fe4abfa Gerrit-Change-Number: 31534 Gerrit-PatchSet: 6 Gerrit-Owner: arehbein <arehb...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: arehbein <arehb...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 03 Mar 2023 09:18:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
