Attention is currently required from: arehbein.

msuraev has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/31591 )

Change subject: osmo_wqueue_enqueue(): Avoid redundant if-check
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Patchset:

PS2:
> The result is basically one function less on the call stack and one
if-check less

Only if we turn off all compiler optimisations. Which pretty-much never happens 
in practice so the actual result is the code which is harder to read.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31591
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3ecc1698e836ca40e178a5b84c2946ae0e6bbfc9
Gerrit-Change-Number: 31591
Gerrit-PatchSet: 2
Gerrit-Owner: arehbein <arehb...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msur...@sysmocom.de>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: arehbein <arehb...@sysmocom.de>
Gerrit-Comment-Date: Wed, 08 Mar 2023 18:42:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to