Attention is currently required from: neels, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741 )
Change subject: build: fix linking gen__pfcp_ies_auto to use build-tree libosmo-gtlv ...................................................................... Patch Set 4: Code-Review+1 (3 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741/comment/e6dfeb5e_380fc298 PS3, Line 15: used > use Done File src/libosmo-pfcp/Makefile.am: https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741/comment/7e11e922_d7912021 PS1, Line 68: gen__pfcp_ies_auto_LDFLAGS > for the record: fixeria is correct; LDFLAGS and LIBS are separate things, and > have always been for a […] Done File src/libosmo-pfcp/Makefile.am: https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741/comment/0963da43_14a3101c PS3, Line 71: COVERAGE_LDFLAGS > This does not belong here and should be done in > https://gerrit.osmocom.org/c/libosmo-pfcp/+/31761. Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I2e92238b214d8e79bab1095d6093139bad05bc66 Gerrit-Change-Number: 31741 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 20:43:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Comment-In-Reply-To: laforge <lafo...@osmocom.org> Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
