Attention is currently required from: arehbein, laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31533 )
Change subject: common: Have PCU socket connection use osmo_wqueue ...................................................................... Patch Set 5: (1 comment) File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/87a0f064_fe79df2e PS2, Line 1102: osmo_fd_write_disable(&state->upqueue.bfd); > I have looked at some of our projects and seen similar code (code that > disables the fd before calling write or transmitting data (probably also > ultimately calling write) in osmo-trx, osmo-bts and libosmo-abis code. That should happen only when the wqueue becomes empty, please have a look at the code and if it's not the case share a detailed example. I see that this can be done in the previous because it's inside a while(!llist_empty()) loop, but then it makes no sense to call it on every loop iteration. In this new code here, you cannot do that. > Probably isn't noticeable because sooner or later, the enable happens, > anyways. Yes, next time a packet is enqueued. That doesn't mean it's correct though. I submitted https://gerrit.osmocom.org/c/osmo-bts/+/31924 to clean up this function, this may amke it easier for you to understand, feel free to rebase your work on top of it. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia6e61dda4b3cd4bba76e6acb7771d70335062fe1 Gerrit-Change-Number: 31533 Gerrit-PatchSet: 5 Gerrit-Owner: arehbein <arehb...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: fixeria <vyanits...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Attention: arehbein <arehb...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Wed, 15 Mar 2023 16:31:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehb...@sysmocom.de> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
