Attention is currently required from: pespin.

Hello Jenkins Builder, pespin,

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/libosmo-gprs/+/31949

to look at the new patch set (#2).

Change subject: rlcmac: fix handling of TIMESLOT_ALLOCATION in 
handle_pkt_dl_ass()
......................................................................

rlcmac: fix handling of TIMESLOT_ALLOCATION in handle_pkt_dl_ass()

The TIMESLOT_ALLOCATION is a timeslot mask with MSB=TS0 and LSB=TS7:

  0 1 2 3 4 5 6 7  TS# in TIMESLOT_ALLOCATION
  0 1 2 3 4 5 6 7  'i' value in the loop, current rshift
  7 6 5 4 3 2 1 0  correct rshift in the loop (this patch)

The current logic checking state of each timeslot is wrong, we
actually need to shift by (7 - N) to check state of timeslot N.

Change-Id: I36c52e282ee02c5136a645eb73a9631b95355c34
Related: OS#5500
---
M src/rlcmac/tbf_dl_ass_fsm.c
1 file changed, 20 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/49/31949/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31949
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I36c52e282ee02c5136a645eb73a9631b95355c34
Gerrit-Change-Number: 31949
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-MessageType: newpatchset

Reply via email to