Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/32083 )

Change subject: mgcp_codec: refactor payload type converstion
......................................................................


Patch Set 1:

(3 comments)

File tests/mgcp/mgcp_test.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5466):
https://gerrit.osmocom.org/c/osmo-mgw/+/32083/comment/090e783f_4b9ab825
PS1, Line 2059:         } else {
else is not generally useful after a break or return


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5466):
https://gerrit.osmocom.org/c/osmo-mgw/+/32083/comment/31efe181_9f0114c9
PS1, Line 2067:         } else {
else is not generally useful after a break or return


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5466):
https://gerrit.osmocom.org/c/osmo-mgw/+/32083/comment/aa30afac_3d9a9b42
PS1, Line 2122:                         result = pt_translate(conn, 0, 
1,expect->payload_type_map[0]);
space required after that ',' (ctx:VxV)



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32083
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I085260a2ca8cfecdb58656b7a046c536189e238d
Gerrit-Change-Number: 32083
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Mon, 27 Mar 2023 13:57:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to