Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32087 )
Change subject: Introduce LOGPLCFN() for logging lchan-name + frame number ...................................................................... Patch Set 3: (1 comment) File src/common/measurement.c: https://gerrit.osmocom.org/c/osmo-bts/+/32087/comment/42041e70_1bba5633 PS3, Line 76: LOGPLCFN(lchan, DMEAS, LOGL_ERROR, fn, "Unsupported lchan->tch_mode %u\n", > This is totally weird. You are passing lchan before DMEAS and LOGL_ERROR, but > "fn" afterwards. […] I would not say "totally"... The current approach is consistent with both LOGPLCHAN and LOGPFN macros: the former accepts lchan as the first argument, the later accepts fn after the logging level. Personally I don't really care, as long as it's more or less consistent. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I214af0448652a9f321ccbab77977b67663ba28f9 Gerrit-Change-Number: 32087 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <lafo...@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 28 Mar 2023 09:09:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
