[S] Change in osmo-bts[master]: bts-{sysmo,oc2g,lc15}: Dump logical channel params during MPH-ACTIVAT...

[laforge]

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/32092 )

Change subject: bts-{sysmo,oc2g,lc15}: Dump logical channel params during 
MPH-ACTIVATE.req
......................................................................

bts-{sysmo,oc2g,lc15}: Dump logical channel params during MPH-ACTIVATE.req

So far we only printed it during later modification.  Let's print
it also during initial activation of a logical channel.

Change-Id: I6982a52905e4719e2e9c40630252ffef2ff9fbed
---
M src/osmo-bts-lc15/oml.c
M src/osmo-bts-oc2g/oml.c
M src/osmo-bts-sysmo/oml.c
3 files changed, 21 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved




diff --git a/src/osmo-bts-lc15/oml.c b/src/osmo-bts-lc15/oml.c
index 675e3fe..7d09a6a 100644
--- a/src/osmo-bts-lc15/oml.c
+++ b/src/osmo-bts-lc15/oml.c
@@ -49,6 +49,8 @@
 #include "lc15bts.h"
 #include "utils.h"

+static void dump_lch_par(int logl, GsmL1_LogChParam_t *lch_par, GsmL1_Sapi_t 
sapi);
+
 static int mph_info_chan_confirm(struct gsm_lchan *lchan,
                        enum osmo_mph_info_type type, uint8_t cause)
 {
@@ -1097,6 +1099,7 @@
        LOGP(DL1C, LOGL_INFO, "%s MPH-ACTIVATE.req (hL2=0x%08x, %s ",
                gsm_lchan_name(lchan), (uint32_t)act_req->hLayer2,
                get_value_string(lc15bts_l1sapi_names, act_req->sapi));
+       dump_lch_par(LOGL_INFO, lch_par, act_req->sapi);
        LOGPC(DL1C, LOGL_INFO, "%s)\n",
                get_value_string(lc15bts_dir_names, act_req->dir));

diff --git a/src/osmo-bts-oc2g/oml.c b/src/osmo-bts-oc2g/oml.c
index d12571b..e3cadbd 100644
--- a/src/osmo-bts-oc2g/oml.c
+++ b/src/osmo-bts-oc2g/oml.c
@@ -49,6 +49,8 @@
 #include "oc2gbts.h"
 #include "utils.h"

+static void dump_lch_par(int logl, GsmL1_LogChParam_t *lch_par, GsmL1_Sapi_t 
sapi);
+
 static int mph_info_chan_confirm(struct gsm_lchan *lchan,
                        enum osmo_mph_info_type type, uint8_t cause)
 {
@@ -1112,6 +1114,7 @@
        LOGP(DL1C, LOGL_INFO, "%s MPH-ACTIVATE.req (hL2=0x%08x, %s ",
                gsm_lchan_name(lchan), (uint32_t)act_req->hLayer2,
                get_value_string(oc2gbts_l1sapi_names, act_req->sapi));
+       dump_lch_par(LOGL_INFO, lch_par, act_req->sapi);
        LOGPC(DL1C, LOGL_INFO, "%s)\n",
                get_value_string(oc2gbts_dir_names, act_req->dir));

diff --git a/src/osmo-bts-sysmo/oml.c b/src/osmo-bts-sysmo/oml.c
index ba60b76..4d1d2a3 100644
--- a/src/osmo-bts-sysmo/oml.c
+++ b/src/osmo-bts-sysmo/oml.c
@@ -46,6 +46,8 @@
 #include "femtobts.h"
 #include "utils.h"

+static void dump_lch_par(int logl, GsmL1_LogChParam_t *lch_par, GsmL1_Sapi_t 
sapi);
+
 static int mph_info_chan_confirm(struct gsm_lchan *lchan,
                        enum osmo_mph_info_type type, uint8_t cause)
 {
@@ -1105,6 +1107,7 @@
        LOGP(DL1C, LOGL_INFO, "%s MPH-ACTIVATE.req (hL2=0x%08x, %s ",
                gsm_lchan_name(lchan), act_req->hLayer2,
                get_value_string(femtobts_l1sapi_names, act_req->sapi));
+       dump_lch_par(LOGL_INFO, lch_par, act_req->sapi);
        LOGPC(DL1C, LOGL_INFO, "%s)\n",
                get_value_string(femtobts_dir_names, act_req->dir));


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32092
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6982a52905e4719e2e9c40630252ffef2ff9fbed
Gerrit-Change-Number: 32092
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-MessageType: merged