Patch Set 1: (2 comments)
next to the question of timeout/age for the entries, I'm wondering how to inquire the current system state. There is no VTY command that can help the administrator to "show" which RAC/LAC are served by a given RNC. https://gerrit.osmocom.org/#/c/5381/1/src/iu_client.c File src/iu_client.c: Line 182: llist_for_each_entry(e, &rnc->lac_rac_list, entry) { we typically introduce a helper function for the look-up. You have this inline list iteration here as well as further down in ranap_iu_rab_act; why not have a "static bool rnc_has_lac_rac()" instead? Line 195: llist_add(&e->entry, &rnc->lac_rac_list); so we always keep adding RAC+LAC to the list but don't ever remove them. This might lead to memory exhaustion and also possible configuration inconsistencies e.g. if you start to reconfigure your network and move a certain LAC from one RNC to another. It would be great if there would be some kind of "age' or "timeout" attached, so that if we haven't seen a given RNC report anything from a given LAC/RAC for some time (let's say an hour?) they get removed again. But then, that might be an optimization left for later on. -- To view, visit https://gerrit.osmocom.org/5381 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I189f8e2663353276b1c615d2f78455dafe568045 Gerrit-PatchSet: 1 Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
