Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32436 )
Change subject: layer23: Use OSMO_IMSI_BUF_SIZE from libosmocore ...................................................................... Patch Set 3: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/32436/comment/366cd0c7_38942382 PS3, Line 8: I'd mention here that GSM_IMSI_LENGTH was 16, and OSMO_IMSI_BUF_SIZE is 17: ``` include/osmocom/gsm/protocol/gsm_23_003.h:#define GSM23003_IMSI_MAX_DIGITS 15 include/osmocom/gsm/protocol/gsm_23_003.h:#define OSMO_IMSI_BUF_SIZE (GSM23003_IMSI_MAX_DIGITS+2) ``` File src/host/layer23/src/common/subscriber.c: https://gerrit.osmocom.org/c/osmocom-bb/+/32436/comment/fc0090d4_0729e360 PS3, Line 232: strlen(imsi) - 1 > OSMO_IMSI_BUF_SIZE - 1 is this still correct? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32436 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I295444bb3b75ed236ea4af5563d9a9c9e590cab7 Gerrit-Change-Number: 32436 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 25 Apr 2023 11:57:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
