Attention is currently required from: laforge, pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31417 )
Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload ...................................................................... Patch Set 7: (3 comments) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/717dbf50_1879a919 PS6, Line 1274: if (OSMO_UNLIKELY((resp_msg->len != GSM_HR_BYTES + 1) && rfc5993)) { > Should this be: […] Yes, I want to know if the received format is not supported. The supported format is either rfc5993 or ts101318. I have swapped the bool value that defines if the format is expected or not at the beginning, this should be easier to read. I am also using the constants you suggested. (I think you mixed up the two formats, at least in the suggested formats you do. RFC5993 is the format with the added ToC byte at the beginning.) https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/0ce53d16_4d3f533c PS6, Line 1279: } else if (OSMO_UNLIKELY((resp_msg->len != GSM_HR_BYTES) && ts101318)) { > same here, !rfc5993 Done https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/dfef7dc8_b894e6c1 PS6, Line 1950: } else if (lchan->type == GSM_LCHAN_TCH_H && rtp_pl_len == GSM_HR_BYTES + 1 > I see you are using "GSM_HR_BYTES" and "GSM_HR_BYTES + 1" in several places. > […] The GSM_HR_BYTES_RTP_ constants should be in libosmocore. We also have to deal with the two formats in osmo-mgw, so they may be of use there as well. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31417 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I453562da412fde5b928bd2b588129c58ec8e2a7e Gerrit-Change-Number: 31417 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Wed, 03 May 2023 14:18:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
