Attention is currently required from: arehbein, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32277 )
Change subject: ctrl: drop deprecated neighbor resolution interface ...................................................................... Patch Set 9: Code-Review-1 (2 comments) File src/osmo-bsc/neighbor_ident_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/32277/comment/143e3894_a7445114 PS8, Line 687: CTRL_CMD_DEFINE_WO(neighbor_cgi_ps_add, "neighbor-cgi-ps add"); I mean why are you dropping these commands here. https://gerrit.osmocom.org/c/osmo-bsc/+/32277/comment/49165217_9cccf5b1 PS8, Line 714: CTRL_CMD_DEFINE_WO(neighbor_cgi_ps_del, "neighbor-cgi-ps del"); and here. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32277 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I93e25856eede4b2f5aa36d8a16714b43d37b4fd0 Gerrit-Change-Number: 32277 Gerrit-PatchSet: 9 Gerrit-Owner: msuraev <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehb...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: arehbein <arehb...@sysmocom.de> Gerrit-Attention: msuraev <msur...@sysmocom.de> Gerrit-Comment-Date: Fri, 05 May 2023 11:03:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment