Attention is currently required from: Hoernchen, fixeria, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libasn1c/+/32612 )
Change subject: Disable _ASN_STACK_OVERFLOW_CHECK if building with Asan enabled ...................................................................... Patch Set 3: (1 comment) File include/asn1c/asn_internal.h: https://gerrit.osmocom.org/c/libasn1c/+/32612/comment/c8c09194_52288a67 PS3, Line 137: _ASN_STACK_OVERFLOW_CHECK(asn_codec_ctx_t *ctx) { > Is this function even useful/used if _ASN_SANITIZE_ENABLED is not defined? yes, it's precisely when it's useful, since that means there's no tool in place to track this kind of possible issues. IMHO it should be dropped and ASan be used insted, but I'm letting upstream decide on that :) -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/32612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: I2dda4720f3ea5a023d340863db177e6334beeaa3 Gerrit-Change-Number: 32612 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Hoernchen <ew...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: Hoernchen <ew...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: daniel <dwillm...@sysmocom.de> Gerrit-Comment-Date: Fri, 05 May 2023 14:38:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillm...@sysmocom.de> Gerrit-MessageType: comment
