neels has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/32576 )
Change subject: vty: move struct vty_parent_node to private API
......................................................................
vty: move struct vty_parent_node to private API
Change-Id: Id2070f03b09feea966c5342361d409551e557d38
---
M TODO-RELEASE
M include/osmocom/vty/vty.h
M src/vty/command.c
3 files changed, 26 insertions(+), 16 deletions(-)
Approvals:
daniel: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/TODO-RELEASE b/TODO-RELEASE
index 2935a81..bade6f5 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -8,4 +8,5 @@
# If any interfaces have been removed or changed since the last public
release: c:r:0.
#library what description / commit summary line
libosmogsm new header osmocom/gsm/protocol/gsm_44_060.h
-libosmocore ADD new defines in osmocom/gsm/protocol/gsm_04_08.h (old ones
marked deprecated)
\ No newline at end of file
+libosmocore ADD new defines in osmocom/gsm/protocol/gsm_04_08.h (old ones
marked deprecated)
+libosmovty drop API drop struct vty_parent_node from public
API, it should never have been public
diff --git a/include/osmocom/vty/vty.h b/include/osmocom/vty/vty.h
index 155501e..3a2ec6f 100644
--- a/include/osmocom/vty/vty.h
+++ b/include/osmocom/vty/vty.h
@@ -56,21 +56,6 @@
VTY_SHELL_SERV
};
-struct vty_parent_node {
- struct llist_head entry;
-
- /*! private data, specified by creator */
- void *priv;
- void *index;
-
- /*! Node status of this vty */
- int node;
-
- /*! When reading from a config file, these are the indenting characters
expected for children of
- * this VTY node. */
- char *indent;
-};
-
/*! Internal representation of a single VTY */
struct vty {
/*! underlying file (if any) */
diff --git a/src/vty/command.c b/src/vty/command.c
index a60b544..e67fd86 100644
--- a/src/vty/command.c
+++ b/src/vty/command.c
@@ -77,6 +77,21 @@
/* Host information structure. */
struct host host;
+struct vty_parent_node {
+ struct llist_head entry;
+
+ /*! private data, specified by creator */
+ void *priv;
+ void *index;
+
+ /*! Node status of this vty */
+ int node;
+
+ /*! When reading from a config file, these are the indenting characters
expected for children of
+ * this VTY node. */
+ char *indent;
+};
+
/* Standard command node structures. */
struct cmd_node auth_node = {
AUTH_NODE,
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32576
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id2070f03b09feea966c5342361d409551e557d38
Gerrit-Change-Number: 32576
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillm...@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-MessageType: merged
