Attention is currently required from: osmith, fixeria, dexter.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/32532 )

Change subject: pySim-shell: fix compatibility problem with cmd2 >= 2.0.0 
(Settable)
......................................................................


Patch Set 14:

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/pysim/+/32532/comment/0b6ba63d_6bbc1b7b
PS8, Line 11: Older versions will ignore the settable_object parameter
> This patch should of course not break support for cmd2 1. […]
incase it matters: you should be able to extend the jenkins build job by 
running twice in different virtual-env, installing different versions of 
dependencies?



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/32532
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I38efe4702277ee092a5542d7d659df08cb0adeff
Gerrit-Change-Number: 32532
Gerrit-PatchSet: 14
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-CC: laforge <lafo...@osmocom.org>
Gerrit-CC: osmith <osm...@sysmocom.de>
Gerrit-Attention: osmith <osm...@sysmocom.de>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Attention: dexter <pma...@sysmocom.de>
Gerrit-Comment-Date: Sat, 06 May 2023 11:43:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
Comment-In-Reply-To: dexter <pma...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to