Attention is currently required from: fixeria, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32606 )
Change subject: PCUIF_Types: add record PCUIF_pch_dt ...................................................................... Patch Set 4: (2 comments) File library/PCUIF_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32606/comment/c40f0af6_98f5a83c PS1, Line 320: octetstring data length(162) > 162 is not bits here, it's actually bytes. […] I think I messed this up. Of course it is 23 bytes. File library/PCUIF_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32606/comment/61a8fbda_bb74102e PS2, Line 319: octetstring > Can we use `charstring` here? It would have been more convenient. I have changed it to charstring now but I also saw IMSI as octetstring in some places. It also appears also sometimes heckstring. If you think it is more convenient we can go with charstring. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia705d3a6fe7adb863acd29e968f8dc6b2066a497 Gerrit-Change-Number: 32606 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 10 May 2023 13:02:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: dexter <pma...@sysmocom.de> Gerrit-MessageType: comment
