Attention is currently required from: fixeria, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32630 )
Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload ...................................................................... Patch Set 5: (4 comments) File include/osmo-bts/bts.h: https://gerrit.osmocom.org/c/osmo-bts/+/32630/comment/f99bfe48_97638d46 PS4, Line 71: 101.138 > TS 101. […] Done File src/common/bts.c: https://gerrit.osmocom.org/c/osmo-bts/+/32630/comment/ad1db125_dc07d005 PS4, Line 208: 101.138 > TS 101. […] Done File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/32630/comment/33f3f112_2e9c7004 PS4, Line 1955: /* Since we already verified the payload in rtppayload_validate_hr(), we may trust that the payload length is > Agreeing with pespin here, his proposed approach looks more readable. […] thanks. File src/osmo-bts-virtual/main.c: https://gerrit.osmocom.org/c/osmo-bts/+/32630/comment/9bd1b5ed_89b40194 PS4, Line 76: BTS_INTERNAL_FLAG_SPEECH_H_V1_RTP_RFC5993 > I am not 100% sure, but osmo-bts-virtual should in theory support both > formats. osmo-bts-virtual does not use gsm0503_tch_hr_encode/decode, so I think you are right. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9419b40c1171876879d41aba4f51c93e8ef5673c Gerrit-Change-Number: 32630 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 22 May 2023 10:01:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
