Attention is currently required from: jolly. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32934 )
Change subject: Add support for receiving Bter UI frames at lapdm.c ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File src/gsm/lapdm.c: https://gerrit.osmocom.org/c/libosmocore/+/32934/comment/20f00d69_35e74258 PS5, Line 730: if (LAPDm_ADDR_SHORT_L2(msg->l2h[2]) == 0x0) { cosmetic: Here you write 0x0, but there is also LAPDm_CTRL_U_BITS(msg->l2h[3]) == 0), which just uses 0 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32934 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If04115884743455c7bf2b2bc5f7e49e74b6ffb60 Gerrit-Change-Number: 32934 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andr...@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: jolly <andr...@eversberg.eu> Gerrit-Comment-Date: Wed, 24 May 2023 15:32:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
