Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32734 )
Change subject: paging: do not confirm PAGING COMMAND messages ...................................................................... Patch Set 7: (1 comment) Patchset: PS6: > IMO, it does not worth to introduce such a layering violation (i.e. […] In osmo-bsc we also distinguish between PAGING COMMAND and IMMEDIATE ASSIGNMENT. and it is done in the same way: https://gitea.osmocom.org/cellular-infrastructure/osmo-bsc/src/branch/master/src/osmo-bsc/pcu_sock.c#L557 (If you think looking directly in the MAC block is a problem then we might consider adding a message type field to struct gsm_pcu_if_pch_dt) The reason why I think that this must be fixed is the following: When we confirm PAGING COMMAND messages as well, then this has the appearance that it would be mandatory to confirm PAGING COMMAND messages. This has caused confusion in the past and we should make sure that we won't run into this again. Also since osmo-bsc does not confirm PAGING COMMAND messages we would end up having two different behaviors. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8b8264d28b1b1deb08774cdba58dd4c6dafe115d Gerrit-Change-Number: 32734 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Mon, 05 Jun 2023 15:33:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Gerrit-MessageType: comment
