Max has submitted this change and it was merged. Change subject: Remove unused includes and forward declarations ......................................................................
Remove unused includes and forward declarations Change-Id: I59da04edd1b8ff965bbfbe00ccae1f7c9b6e5301 --- M src/gprs_bssgp_pcu.cpp M src/gprs_debug.cpp M src/gprs_debug.h M src/gprs_ms.h M src/gprs_rlcmac.cpp M src/gprs_rlcmac.h M src/llc.cpp M src/llc.h M src/rlc.cpp M src/rlc.h M src/sba.h M src/tbf.h 12 files changed, 0 insertions(+), 24 deletions(-) Approvals: Neels Hofmeyr: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp index 7b78e2f..a86e09d 100644 --- a/src/gprs_bssgp_pcu.cpp +++ b/src/gprs_bssgp_pcu.cpp @@ -23,7 +23,6 @@ #include <pcu_l1_if.h> #include <bts.h> #include <tbf.h> -#include <decoding.h> #define BSSGP_TIMER_T1 30 /* Guards the (un)blocking procedures */ #define BSSGP_TIMER_T2 30 /* Guards the reset procedure */ diff --git a/src/gprs_debug.cpp b/src/gprs_debug.cpp index c35eafa..283962f 100644 --- a/src/gprs_debug.cpp +++ b/src/gprs_debug.cpp @@ -16,16 +16,7 @@ * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ - -#include <stdarg.h> -#include <stdlib.h> -#include <stdio.h> -#include <string.h> -#include <strings.h> -#include <time.h> -#include <errno.h> -#include <osmocom/core/talloc.h> #include <osmocom/core/utils.h> #include <osmocom/core/logging.h> #include <gprs_debug.h> diff --git a/src/gprs_debug.h b/src/gprs_debug.h index 863d76b..747465b 100644 --- a/src/gprs_debug.h +++ b/src/gprs_debug.h @@ -19,11 +19,9 @@ #pragma once -#include <stdio.h> #ifdef __cplusplus extern "C" { #endif -#include <osmocom/core/linuxlist.h> #include <osmocom/core/logging.h> #ifdef __cplusplus }; diff --git a/src/gprs_ms.h b/src/gprs_ms.h index 72a86c9..f094e96 100644 --- a/src/gprs_ms.h +++ b/src/gprs_ms.h @@ -20,9 +20,6 @@ #pragma once -struct gprs_rlcmac_tbf; -struct gprs_rlcmac_dl_tbf; -struct gprs_rlcmac_ul_tbf; struct gprs_codel; #include "cxx_linuxlist.h" diff --git a/src/gprs_rlcmac.cpp b/src/gprs_rlcmac.cpp index 16870c3..06c5479 100644 --- a/src/gprs_rlcmac.cpp +++ b/src/gprs_rlcmac.cpp @@ -19,7 +19,6 @@ * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ -#include <gprs_bssgp_pcu.h> #include <pcu_l1_if.h> #include <gprs_rlcmac.h> #include <bts.h> diff --git a/src/gprs_rlcmac.h b/src/gprs_rlcmac.h index be1e686..aa773fc 100644 --- a/src/gprs_rlcmac.h +++ b/src/gprs_rlcmac.h @@ -41,7 +41,6 @@ struct gprs_rlcmac_tbf; struct gprs_rlcmac_bts; -struct BTS; struct GprsMs; #ifdef __cplusplus diff --git a/src/llc.cpp b/src/llc.cpp index 79afc37..b155063 100644 --- a/src/llc.cpp +++ b/src/llc.cpp @@ -19,7 +19,6 @@ * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ -#include <tbf.h> #include <bts.h> #include <stdio.h> diff --git a/src/llc.h b/src/llc.h index 4883624..9d402c3 100644 --- a/src/llc.h +++ b/src/llc.h @@ -29,7 +29,6 @@ #define LLC_MAX_LEN 1543 struct BTS; -struct timeval; struct msgb; /** diff --git a/src/rlc.cpp b/src/rlc.cpp index c52417d..37e83cd 100644 --- a/src/rlc.cpp +++ b/src/rlc.cpp @@ -16,7 +16,6 @@ * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ -#include "tbf.h" #include "bts.h" #include "gprs_debug.h" diff --git a/src/rlc.h b/src/rlc.h index 14d2082..b62e3ac 100644 --- a/src/rlc.h +++ b/src/rlc.h @@ -36,7 +36,6 @@ #define RLC_MAX_LEN 74 /* MCS-9 data unit */ struct BTS; -struct gprs_rlc_v_n; /* The state of a BSN in the send/receive window */ enum gprs_rlc_ul_bsn_state { diff --git a/src/sba.h b/src/sba.h index 9047f1a..d2d3106 100644 --- a/src/sba.h +++ b/src/sba.h @@ -28,7 +28,6 @@ struct BTS; class PollController; -struct gprs_rlcmac_sba; struct gprs_rlcmac_pdch; /* diff --git a/src/tbf.h b/src/tbf.h index 518bd9b..9a1b4c7 100644 --- a/src/tbf.h +++ b/src/tbf.h @@ -32,8 +32,6 @@ } struct bssgp_bvc_ctx; -struct rlc_ul_header; -struct msgb; struct pcu_l1_meas; class GprsMs; -- To view, visit https://gerrit.osmocom.org/5403 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59da04edd1b8ff965bbfbe00ccae1f7c9b6e5301 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>