Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33400 )
Change subject: Fix various uninitialized value errors ...................................................................... Patch Set 1: (1 comment) File src/gsm/gsm23236.c: https://gerrit.osmocom.org/c/libosmocore/+/33400/comment/2cd7f9b9_034e2aca PS1, Line 490: struct osmo_nri_range add_range = {}; > Then I see no problem? everything is as expected? Coverity is basically unhappy because at line 497 we're copying a struct with partly-initialized fields. This can be easily solved by moving it below the check at line 499, as you suggested. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icaf53fda8752e9d2bd2cfe8c7b89bb31b90f684f Gerrit-Change-Number: 33400 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jun 2023 11:47:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Gerrit-MessageType: comment
