Attention is currently required from: arehbein, laforge, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33201 )
Change subject: stream: Add and use IPA send function ...................................................................... Patch Set 12: (3 comments) Patchset: PS12: Some of your own comments seem to not be addressed yet. File examples/ipa-stream-client.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/e5c8d326_1321339e PS11, Line 109: if (osmo_ipa_process_msg(msg) < 0) { > Remove this, it's now handled in the segmentation_cb what about this comment? File include/osmocom/netif/ipa.h: https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/bbad6fe2_9d515c57 PS12, Line 57: #define IPAC_PROTO_UNSPECIFIED -1 it's a bit strange to declare this here while others are probably declared somewhere else? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33201 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I61e1fe59166c46595efe8c1f32b8f2607cb6c529 Gerrit-Change-Number: 33201 Gerrit-PatchSet: 12 Gerrit-Owner: arehbein <arehb...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: daniel <dwillm...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Attention: arehbein <arehb...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: daniel <dwillm...@sysmocom.de> Gerrit-Comment-Date: Mon, 24 Jul 2023 10:25:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillm...@sysmocom.de> Gerrit-MessageType: comment
