Attention is currently required from: daniel, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34338?usp=email )
Change subject: stream_srv: Fix connection error handling ...................................................................... Patch Set 2: (1 comment) File src/stream_srv.c: https://gerrit.osmocom.org/c/libosmo-netif/+/34338/comment/3167b696_d6911e84 PS1, Line 493: if (conn->flags & OSMO_STREAM_SRV_F_FLUSH_DESTROY) { > You're right, thanks! It's also leaking msg if iofd_read_cb is not set, > though I'm unsure how common […] for a srv it is probably unlikely or unusable. In general there are sitautions where there are fds that are only written to (or read from), at least from one process. Think of eventfd that are only written to by the producer thread/process. Or think of a classic uni-directional unix fifo/pipe. But the stream_srv would only exist for things that have a "listen + process incoming connection" kind of paradigm, where you would always have some reading going on? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34338?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I84eea2717f3762830f3f5b115e6fc8545eaa4fd5 Gerrit-Change-Number: 34338 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: daniel <dwillm...@sysmocom.de> Gerrit-Comment-Date: Tue, 12 Sep 2023 09:25:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: daniel <dwillm...@sysmocom.de> Gerrit-MessageType: comment
