Attention is currently required from: daniel, pespin.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34337?usp=email )

Change subject: osmo_io: Init iofd_msghdr to zero
......................................................................


Patch Set 1:

(1 comment)

File src/core/osmo_io_poll.c:

https://gerrit.osmocom.org/c/libosmocore/+/34337/comment/d6f53cbd_a0d9c771
PS1, Line 58:           hdr.msg = msg;
> Better do hdr = {}; here while adding the other fields, otherwise you are 
> memzeroing twice. […]
it's a rather trivial change delaying the merge already for a week.  Can we 
please get this implemented so the patch can proceed?



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34337?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I21114ad57784126cfdeb4a932ed44dbf23946fbe
Gerrit-Change-Number: 34337
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-CC: laforge <lafo...@osmocom.org>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Attention: daniel <dwillm...@sysmocom.de>
Gerrit-Comment-Date: Thu, 14 Sep 2023 06:21:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to