Attention is currently required from: laforge, neels.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34417?usp=email )

Change subject: sip: test SDP forwarding via MNCC
......................................................................


Patch Set 2:

(1 comment)

File sip/SIP_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34417/comment/78ba940c_f48bccf7
PS2, Line 241: log("FAIL: expected SDP ", expect_sdp, " but got ", last_sdp);
             :          setverdict(fail, "unexpected SDP");
             :          mtc.stop;
> see my comment in the other patch. mege log+setverdict, or even go for 
> Misc_Helpers. […]
Misc_Helpers.f_shutdown() please



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34417?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib2ae8449e673f5027f01d428d3718c006f76d93e
Gerrit-Change-Number: 34417
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <lafo...@osmocom.org>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: neels <nhofm...@sysmocom.de>
Gerrit-Attention: laforge <lafo...@osmocom.org>
Gerrit-Comment-Date: Thu, 14 Sep 2023 11:22:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <lafo...@osmocom.org>
Gerrit-MessageType: comment

Reply via email to