Attention is currently required from: keith, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/16222?usp=email )
Change subject: forward SDP between SIP and MNCC ...................................................................... Patch Set 9: -Code-Review (1 comment) File src/sip.c: https://gerrit.osmocom.org/c/osmo-sip-connector/+/16222/comment/368f1bd1_213d4abb PS9, Line 549: SIPTAG_PAYLOAD_STR(sdp), > I'm slightly concerned about introducing the sending of SDP with the 180. […] many thanks for this feedback! I compared with some SIP traces which confirm your concerns. I removed SDP here, and fixed the ttcn3 tests accordingly. resubmitting in a minute. -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/16222?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I3df5d06f38ee2d122706a9ebffde7db4f2bd6bae Gerrit-Change-Number: 16222 Gerrit-PatchSet: 9 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <ke...@rhizomatica.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: keith <ke...@rhizomatica.org> Gerrit-Comment-Date: Fri, 15 Sep 2023 02:18:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: keith <ke...@rhizomatica.org> Gerrit-MessageType: comment
