Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34442?usp=email )
Change subject: nm: delay RSL connect until BBTRANSC object is OPSTARTed ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/common/nm_bb_transc_fsm.c: https://gerrit.osmocom.org/c/osmo-bts/+/34442/comment/41ae1aa5_0d7f19fe PS1, Line 143: Disabled because osmo-bsc doesn't send SetAttr on BB_TRANSC object If I read 3GPP TS 52.021 correctly, there exists no `Set Attributes` procedure for the `Baseband Transceiver` object at all, so this code chunk should be removed. Unrelated to this patch, just mentioning. https://gerrit.osmocom.org/c/osmo-bts/+/34442/comment/a23ccaf6_d1dea33d PS1, Line 157: LOGL_NOTICE `LOGL_ERROR` maybe? Ah, you're just moving the existing code. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34442?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idefc65a8812abd49fb5f0cd7b0bef423536b86e0 Gerrit-Change-Number: 34442 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 15 Sep 2023 18:28:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
