Attention is currently required from: jolly.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/34423?usp=email )

Change subject: ASCI: Ignore LAPD frames from MS, while the uplink is not active
......................................................................


Patch Set 1:

(1 comment)

File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/34423/comment/ae57d9e3_a38ed1b0
PS1, Line 1814: rsl_chan_rt_is_asci
I am wondering if the new check you added can be integrated here as follows:

```
if (rsl_chan_rt_is_asci(lchan->rsl_chan_rt) {
    if (lchan->asci.talker_active == VGCS_TALKER_WAIT_FRAME)
        vgcs_talker_frame(lchan);
    if (lchan->asci.talker_active != VGCS_TALKER_ACTIVE)
        return 0;
    }
}
```



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34423?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5075115123055b2997481f56ddf473430a1dc9e3
Gerrit-Change-Number: 34423
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andr...@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanits...@sysmocom.de>
Gerrit-Attention: jolly <andr...@eversberg.eu>
Gerrit-Comment-Date: Fri, 15 Sep 2023 19:58:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to