Attention is currently required from: laforge. manawyrm has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34457?usp=email )
Change subject: gsmtap.h: Add definitions for ISDN PPP sub-type ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > as there is both synchronous PPP over ISDN (the one you're describing here, > where the HDLC around th […] the only relevant difference in the protocol (after the framing) seems to be that the async mode can also have an asyncmap (listing a number of bytes which must not be sent over the line, like XON/XOFF). It might make sense to indicate here that it's meant for Synchronous ISDN, but all of the "specialties" of RFC1618 (framing, NRZ vs. NRZI, etc.) are already gone by this point (because these frames only contain the payload). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34457?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I17137167b2c74b6c5e53459743b6e140fc1a4386 Gerrit-Change-Number: 34457 Gerrit-PatchSet: 2 Gerrit-Owner: manawyrm <osmocom.acco...@tbspace.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Tue, 19 Sep 2023 11:49:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <lafo...@osmocom.org> Gerrit-MessageType: comment
