Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34454?usp=email )
Change subject: oml: ipacc: add missing is_ipa_abisip_bts() checks ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > My point asking was/is: why do we care about the type of BTS in use? Because one can have multiple BTS configured in osmo-bsc.cfg, and they can be of different types (this is what you're doing, IIRC). I know that other BTS models use their own A-bis/OML dialects or even completely different protocols, but the point still applies: this file is called `bts_ipaccess_nanobts.c` and among with the general logic defines handling of ip.access specific MOs and protocol extensions. This is why we already doing this check here in this file, but so far not in all functions. Does that make sense for you? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34454?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I088ff75f2048e54e4bfd926a79c1dcf27b4fb3a4 Gerrit-Change-Number: 34454 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: osmith <osm...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 19 Sep 2023 14:32:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
