Attention is currently required from: jolly. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34491?usp=email )
Change subject: ASCI: Add group receive and transmit mode support to RR layer ...................................................................... Patch Set 2: (5 comments) File src/host/layer23/src/mobile/gsm48_rr.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11187): https://gerrit.osmocom.org/c/osmocom-bb/+/34491/comment/3c4cbcfc_3896902e PS2, Line 510: while((msg = msgb_dequeue(&rr->downqueue))) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11187): https://gerrit.osmocom.org/c/osmocom-bb/+/34491/comment/a70ff070_d9203d79 PS2, Line 1529: if (bitvec_get_bit_high(&bv) == H) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11187): https://gerrit.osmocom.org/c/osmocom-bb/+/34491/comment/7e4c8b7a_3a849f2a PS2, Line 1963: /* Note: Other informations are not used. */ 'informations' may be misspelled - perhaps 'information'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11187): https://gerrit.osmocom.org/c/osmocom-bb/+/34491/comment/55485bd5_cac4ac8e PS2, Line 5501: reject: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11187): https://gerrit.osmocom.org/c/osmocom-bb/+/34491/comment/286eef42_178bfe11 PS2, Line 6389: /* Leave uplink, wait for uplink beeing free, channel release or channel/link failure. */ 'beeing' may be misspelled - perhaps 'being'? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia55c182a1b4cde777a0e16dcfe0cd32e0f2e38eb Gerrit-Change-Number: 34491 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andr...@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andr...@eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 10:34:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
