Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34476?usp=email )
Change subject: ASCI: Add GCC/BCC (call control) to mobility management ...................................................................... Patch Set 3: (3 comments) File src/host/layer23/src/mobile/gsm48_mm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34476/comment/2f157f65_9ab36e21 PS3, Line 789: case GSM48_MMGCC_CLASS: Maybe some explanation why is this added here ad does nothing? https://gerrit.osmocom.org/c/osmocom-bb/+/34476/comment/7fd209d7_6af18d9d PS3, Line 4096: mm_conn_new_ref++); wrong indentation. You can actually put it in the same line. https://gerrit.osmocom.org/c/osmocom-bb/+/34476/comment/3ef173dd_0f012d4a PS3, Line 4114: || mm->state == GSM48_MM_ST_RR_CONN_RELEASE_NA) { wrong indentation. I personally prefer: if (mm->state == GSM48_MM_ST_WAIT_NETWORK_CMD || mm->state == GSM48_MM_ST_RR_CONN_RELEASE_NA) { while some other people prefer: if (mm->state == GSM48_MM_ST_WAIT_NETWORK_CMD || mm->state == GSM48_MM_ST_RR_CONN_RELEASE_NA) { -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34476?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If6f3cea4b2ca839559596a6ee5a3d169c6d85dbe Gerrit-Change-Number: 34476 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andr...@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: jolly <andr...@eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 12:25:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
