Attention is currently required from: fixeria, jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34479?usp=email )
Change subject: ASCI: Add a flag to turn transmitter off or on ...................................................................... Patch Set 5: (2 comments) File include/l1ctl_proto.h: https://gerrit.osmocom.org/c/osmocom-bb/+/34479/comment/4e84bd6c_f5eaf139 PS5, Line 217: uint8_t tch_flags; this means we probably need to update the L1CTL implementations everywhere, eg TTCN3. Do we have some versioning of the proto? maybe move it to the end? File src/host/layer23/src/mobile/gsm48_rr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34479/comment/9b358913_e98ba6f4 PS5, Line 3042: LOGP(DRR, LOGL_INFO, " Channel type %d, subch %d, ts %d, mode %d, audio-mode %d, flags %d, cipher %d\n", you most probably want to print flags with 0x02%x here -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34479?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I20133523adc3b204cd2181bfe664fe66020a10e3 Gerrit-Change-Number: 34479 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andr...@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: jolly <andr...@eversberg.eu> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 12:36:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment