Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34484?usp=email )
Change subject: Refactoring encoding of mobile identity at mobile application ...................................................................... Patch Set 5: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/34484/comment/d318655e_786fbc18 PS5, Line 9: Deprecated functions gsm48_generate_mid_from_*() are replaced by yay! \o/ Patchset: PS5: Just to make sure, did you test a bit this? This kind of patches can easily add regressions. laforge already submitted a similar once a few weeks/months ago and I think it is still in gerrit because I spotted some possible regressions. File src/host/layer23/src/mobile/gsm48_mm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34484/comment/1f598f90_00b0d62c PS5, Line 276: int gsm48_encode_mi(struct osmocom_ms *ms, struct msgb *msg, bool tlv, uint8_t mi_type, bool emergency_imsi) Did you think about having 2 functions gsm48_encode_mi_tlv() and gsm48_encode_mi_lv()? Then have: gsm48_encode_mi_tlv(..) { msgb_put_u8(msg, GSM48_IE_MOBILE_ID); return gsm48_encode_mi_lv(...) } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34484?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9ff429bd50d718530fdad64a276053a35c8928f2 Gerrit-Change-Number: 34484 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andr...@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: jolly <andr...@eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 12:48:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
