Attention is currently required from: jolly, pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34481?usp=email )

Change subject: [WIP] HO: Transmit access bursts on DCCH of TCH channels
......................................................................


Patch Set 5:

(1 comment)

File src/target/firmware/layer1/prim_rach.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/34481/comment/c6f5daa2_bb45ccbc
PS5, Line 161:  fn_sched %= 2715648;
> what's this number? I bet we have a define for it.
It's the maximum possible TDMA Fn value. We do have `GSM_TDMA_HYPERFRAME` in 
libosmocore.git, but it's not accessible from the firmware because we're 
building against a very old local copy. But that old copy has `GSM_MAX_FN` in 
`include/osmocom/gsm/gsm_utils.h` which can be used here.



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34481?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I1a972d9bac5749c67c1b139825400854f7cf1490
Gerrit-Change-Number: 34481
Gerrit-PatchSet: 5
Gerrit-Owner: jolly <andr...@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanits...@sysmocom.de>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: jolly <andr...@eversberg.eu>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Sep 2023 21:57:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to