Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31878?usp=email )
Change subject: Make RLC timing data configurable ...................................................................... Patch Set 2: Code-Review-1 (4 comments) File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/a61bd56e_ec5da31f PS2, Line 50: #define GSM_N3101_STRICT_LOWER_BOUND 8UL STRICT_LOWER_BOUND means simply "MIN" ? :D File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/e034c27c_d4b4cc66 PS2, Line 234: struct osmo_tdef *tdefs = bts->network->T_defs; Nope! this should be per BTS. File src/osmo-bsc/net_init.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/8374a212_e60bc359 PS2, Line 51: { .T = 3142, .default_val = 20, I know tons of parameters are already added here, but we should not continue adding BTS-specific parameters here, it just doesn't make sense. Some of them even may not be configurable on other BTS types. So we really need to add a osmo_tdef group per bts object. You can have a look at asp->cfg.T_defs_lm in libosmo-sccp/src/osmo_ss7_asp.c:673 to find out how to add a T_def instance per object (as opposed to a single structure per process like the gsm_network_T_defs here). Basically: """ asp->cfg.T_defs_lm = talloc_memdup(asp, ss7_asp_lm_timer_defaults, sizeof(ss7_asp_lm_timer_defaults)); osmo_tdefs_reset(asp->cfg.T_defs_lm); """ BTW, when doing so, also create different T_Def groups, like done in this same file here (see bsc_tdef_group below). File tests/nanobts_omlattr/nanobts_omlattr_test.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/3ef734d5_8dabb0d1 PS2, Line 228: 0x02, 0x00, 0x02, 0xa3, 0x00, 0x09, why is this changing? are you changing the default values? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2c24110d8c977d6cc74c3c8e77bcc709ad9d2675 Gerrit-Change-Number: 31878 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehb...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: arehbein <arehb...@sysmocom.de> Gerrit-Comment-Date: Fri, 22 Sep 2023 16:42:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
