Attention is currently required from: fixeria, pespin.

jolly has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34483?usp=email )

Change subject: ASCI: Add support flags to mobile (and VTY) for VGCS/VBS
......................................................................


Patch Set 6:

(2 comments)

File src/host/layer23/include/osmocom/bb/common/settings.h:

https://gerrit.osmocom.org/c/osmocom-bb/+/34483/comment/3a3192f3_4eedbf18
PS5, Line 165:  uint8_t                 vgcs; /* support of VGCS */
> IMO, we either change the existing code to use `bool` and then require all 
> new fields to be `bool` o […]
Done


File src/host/layer23/src/common/support.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/34483/comment/dc4b2909_2007d2cb
PS5, Line 37:   sup->vgcs = 1; /* yes */
> = true
Done



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34483?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ia23eb190e533660cce4ba4c856a83b5f3d534202
Gerrit-Change-Number: 34483
Gerrit-PatchSet: 6
Gerrit-Owner: jolly <andr...@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Tue, 26 Sep 2023 10:25:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to