Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34492?usp=email )
Change subject: ASCI: Add group receive and transmit mode support to MM layer ...................................................................... Patch Set 8: (3 comments) File src/host/layer23/src/mobile/gsm48_mm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34492/comment/10ea07b5_7619540d PS8, Line 4643: if (rr_prim != -1) { Doing `goto` from the `default` branch above might be a more elegant solution. (Gerrit highlighting is rather confusing, it looks as if the whole block was changed, but actually it was only shifted right). https://gerrit.osmocom.org/c/osmocom-bb/+/34492/comment/53ededef_24de43e8 PS8, Line 4813: nothing here TODO/FIXME? https://gerrit.osmocom.org/c/osmocom-bb/+/34492/comment/82842821_cdcae8a9 PS8, Line 4851: nothing here TODO/FIXME? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34492?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I05957182a57423ad947ab200b52f65fde859e110 Gerrit-Change-Number: 34492 Gerrit-PatchSet: 8 Gerrit-Owner: jolly <andr...@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: jolly <andr...@eversberg.eu> Gerrit-Comment-Date: Tue, 26 Sep 2023 15:39:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
