Attention is currently required from: osmith, pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34542?usp=email )

Change subject: bsc: add test TC_ncc_permitted_si2
......................................................................


Patch Set 1:

(2 comments)

File bsc/BSC_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34542/comment/053b4155_ee28e087
PS1, Line 12399: System Information Type 2
btw, this IE is also present in SI Type 6. Do we want to test it too?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34542/comment/5da62dce_74d4f6a1
PS1, Line 12798: TC_ncc_permitted_si2
How about naming this testcase `TC_si2_ncc_permitted` and moving closer to 
other `TC_si*` testcases above in the list? This way it's more consistent.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34542?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibff5c4392d8c19b5bce479b6fa5e33086cdb1272
Gerrit-Change-Number: 34542
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-CC: fixeria <vyanits...@sysmocom.de>
Gerrit-Attention: osmith <osm...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Sep 2023 12:25:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to