Attention is currently required from: dexter.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/34648?usp=email )

Change subject: pcuif_proto: signal BTS model via PCUIF
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

File include/osmo-bts/pcuif_proto.h:

https://gerrit.osmocom.org/c/osmo-bts/+/34648/comment/80ec5249_91385469
PS3, Line 63: /* BTS model */
same comments as osmo-pcu patch.


File src/common/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bts/+/34648/comment/49c7a90c_81116246
PS3, Line 363:  switch (bts->variant) {
maybe move this to a helper function?



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34648?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib51238a0e09d4484a539a7f822864189872698b6
Gerrit-Change-Number: 34648
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: dexter <pma...@sysmocom.de>
Gerrit-Comment-Date: Thu, 05 Oct 2023 11:43:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to