Attention is currently required from: pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34799?usp=email )
Change subject: stream_test: Improve mem mgmt, fix connection mgmt ...................................................................... Patch Set 3: (3 comments) File tests/stream/stream_test.c: https://gerrit.osmocom.org/c/libosmo-netif/+/34799/comment/83301c5d_16fff92c PS3, Line 549: osmo_stream_cli_set_data(osc, ctx); @pes...@sysmocom.de removal of instruction to set data https://gerrit.osmocom.org/c/libosmo-netif/+/34799/comment/eccf3c5e_ac5540a5 PS3, Line 798: osmo_stream_cli_set_data(osc, ctx); @pes...@sysmocom.de removal of instruction to set data File tests/stream/stream_test.ok: https://gerrit.osmocom.org/c/libosmo-netif/+/34799/comment/01da628c_a1cd3d7f PS3, Line 52: {20.000020} [NA] Client's test_segm_ipa_stream_srv_cli_connect_cb(): [1-cli] Appending msg of type IPAC_MSGT_PING into buffer > why this this output change? It's due to the change of memory management in the test. Before the patch, the client side would set newly created talloc contexts as data for the client connection, this has been removed. I have tagged you in the respective lines. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34799?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I9ef02ed113bc049ae430b93d0eb69641e2ee809b Gerrit-Change-Number: 34799 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein <arehb...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 18 Oct 2023 13:58:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
