laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-cbc/+/34812?usp=email )
Change subject: cbc-apitool: Make character set configurable
......................................................................
cbc-apitool: Make character set configurable
osmo-cbc already supported the transmission of UCS2 characters for quite
some time. However, the cbc-apitool didn't expose this capability so
far.
Change-Id: Ia7291238f3b0af8ff9f476fce9a7805e12821d8c
Related: OS#6028
---
M contrib/cbc-apitool.py
M doc/manuals/chapters/cbc-apitool.adoc
2 files changed, 18 insertions(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/contrib/cbc-apitool.py b/contrib/cbc-apitool.py
index 299846a..918119f 100755
--- a/contrib/cbc-apitool.py
+++ b/contrib/cbc-apitool.py
@@ -63,7 +63,7 @@
},
'payload': {
'payload_decoded': {
- 'character_set': "gsm",
+ 'character_set': args.character_set,
#'language': 'en',
'data_utf8': args.payload_data_utf8,
#'data_utf8': "Mahlzeit1 Mahlzeit2 Mahlzeit3 Mahlzeit4
Mahlzeit5 Mahlzeit6 Mahlzeit7 Mahlzeit8"
@@ -126,6 +126,7 @@
parser_c_cbs.add_argument("--repetition-period", type=int,
help='Repetition Period', default=5)
parser_c_cbs.add_argument("--num-of-bcast", type=int, help='Number of
Broadcasts', default=999)
parser_c_cbs.add_argument("--payload-data-utf8", type=str, help='Payload
Data in UTF8', required=True)
+ parser_c_cbs.add_argument("--character-set", type=str, help='Character
Set', default="gsm", choices=["gsm","ucs2","8bit"])
parser_c_cbs.set_defaults(func=do_create_cbs)
parser_c_etws = subparsers.add_parser('create-etws', help='Create a new
ETWS message')
diff --git a/doc/manuals/chapters/cbc-apitool.adoc
b/doc/manuals/chapters/cbc-apitool.adoc
index 145d845..fc435a6 100644
--- a/doc/manuals/chapters/cbc-apitool.adoc
+++ b/doc/manuals/chapters/cbc-apitool.adoc
@@ -50,6 +50,8 @@
*--payload-data-utf8 PAYLOAD_DATA_UTF8*::
Payload data (typically text message) in UTF8 encoding. Will be
transcoded to 7bit GSM alphabet internally.
+*--character-set {gsm,8bit,ucs2}*::
+ Character set to be used for the message. Default: gsm
==== `create-etws` Options
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/34812?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: Ia7291238f3b0af8ff9f476fce9a7805e12821d8c
Gerrit-Change-Number: 34812
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-MessageType: merged
