Attention is currently required from: fixeria, laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email )
Change subject: ASCI: Add System Information 10 support ...................................................................... Patch Set 5: (3 comments) Patchset: PS2: > I don't have a strong preference here... […] There is a better solution, I used to resolve this problem: The channels are activated quite quickly after each other. The BTS will take a while, to acknowledge the channel activations or reject them. The BSC will wait until all requested channels have been activated or rejected. Then the SI10 is generated. This way the SI10 is generated and sent to the BTSs only once. In case the channels are requested with a delay (congestions/errors on the A-Interface), the BSC will generate SI10 as soon as all (so fare) requested channels have been activated or rejected. Then, if more channels get requested by the MSC later, the BSC will update SI10, when all further channels have been activated or rejected. File src/osmo-bsc/system_information.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/0105248a_3ab27112 PS2, Line 1428: unsigned int save_cur_bit; : struct gsm_subscriber_connection *c; > variables should always be declared with the smallest possible scope. […] Done File src/osmo-bsc/system_information.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/baeacfa9_64818519 PS4, Line 1456: llist_for_each_entry(c, &conn->vgcs_chan.call->vgcs_call.chan_list, vgcs_chan.list) { > I always want to separate variables from code. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icd3101e6dd935a57f003253aaef400c2cf95a0c3 Gerrit-Change-Number: 34626 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andr...@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 19 Oct 2023 14:22:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andr...@eversberg.eu> Comment-In-Reply-To: laforge <lafo...@osmocom.org> Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
