Attention is currently required from: laforge, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34735?usp=email )
Change subject: Add IPv6 support ...................................................................... Patch Set 2: Code-Review+1 (4 comments) File src/gtp-genl.c: https://gerrit.osmocom.org/c/libgtpnl/+/34735/comment/10e8a343_fd652bb7 PS2, Line 60: } default: assert() https://gerrit.osmocom.org/c/libgtpnl/+/34735/comment/696be098_103d2406 PS2, Line 69: } default: assert() https://gerrit.osmocom.org/c/libgtpnl/+/34735/comment/2c28aec1_c99fa3a7 PS2, Line 239: switch (pdp.ms_addr.family) { All this can simply be: inet_ntop(pdp.ms_addr.family, &pdp.ms_addr.ip4, buf, sizeof(buf)); https://gerrit.osmocom.org/c/libgtpnl/+/34735/comment/15e9f1bb_e05a5cec PS2, Line 249: switch (pdp.sgsn_addr.family) { inet_ntop(pdp.sgsn_addr.family, &pdp.sgsn_addr.ip4, buf, sizeof(buf)); -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34735?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: If864c9170f74af52a95cbc4cdb1b866e0309306b Gerrit-Change-Number: 34735 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Attention: osmith <osm...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Thu, 19 Oct 2023 14:30:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
