Attention is currently required from: fixeria, laforge, pespin.

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email )

Change subject: Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp
......................................................................


Patch Set 4:

(3 comments)

Patchset:

PS4:
Isn't there a GTPv2 ping/pong or keepalive?

I think we need to implement this procedure.


File src/epdg_gtpc_s2b.erl:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804/comment/ca2ca488_6b71c28a
PS4, Line 10: % This program is free software; you can redistribute it and/or 
modify
In general on this project: We should have a separate discussion about the 
license. I don't know if we're compatible here with AGPL.


https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804/comment/5bb9a8af_1d83d1d9
PS4, Line 60: %% TODO: make APN configurable? get it from HSS?
The UE sends the APN when connecting to the ePDG within the IKEv2.
It's part of the identity.



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I6f00b7fce2d5fcdc484bfd45629b9141f16bc579
Gerrit-Change-Number: 34804
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu>
Gerrit-Attention: laforge <lafo...@osmocom.org>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Mon, 23 Oct 2023 13:01:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to