Attention is currently required from: fixeria, lynxis lazus, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34895?usp=email )
Change subject: epdg: Test Handover from Wifi back to LTE ...................................................................... Patch Set 2: Code-Review+1 (3 comments) File epdg/EPDG_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34895/comment/9baa7167_e3687e0e PS1, Line 451: setverdict(pass); > you explicitly mention cause="Access changed from non-3gpp to 3gpp" below. […] (unresolved) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34895/comment/ccb57ada_263f8483 PS1, Line 459: /* f_gtp2_register_udmsg('63'O); TODO: is this needed? */ > do you want to keep this? (if the test works without it, I guess it is not > needed?) Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34895/comment/4215a235_c65b30fb PS1, Line 533: Brearer > Bearer Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34895?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I299faf28fa51dbc5d2de6c72a39a01eca67a5775 Gerrit-Change-Number: 34895 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: lynxis lazus <lyn...@fe80.eu> Gerrit-Comment-Date: Thu, 26 Oct 2023 12:55:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osm...@sysmocom.de> Gerrit-MessageType: comment