Attention is currently required from: Hoernchen, laforge. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30633?usp=email )
Change subject: logging: add log level cache ...................................................................... Patch Set 12: (2 comments) Patchset: PS9: > Ping, another month has passed? If it's about not introducing a new define... can we not use `UINT8_MAX`? With this it's also quite clear that we can't get any higher number (from what I can tell, internally log levels are always stored as `uint8_t`; `log_cache_update()` also takes `uint8_t` for its level argument) File src/core/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/30633/comment/85774041_2c819416 PS12, Line 153: logging I would suggest > if logging should happen for at least one log target -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30633?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I35f8dd9127dd6e7feae392094fd6b3ce2d32558d Gerrit-Change-Number: 30633 Gerrit-PatchSet: 12 Gerrit-Owner: Hoernchen <ew...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: arehbein <arehb...@sysmocom.de> Gerrit-CC: fixeria <vyanits...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: Hoernchen <ew...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Mon, 06 Nov 2023 23:28:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ew...@sysmocom.de> Comment-In-Reply-To: laforge <lafo...@osmocom.org> Gerrit-MessageType: comment
