Attention is currently required from: jolly. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34985?usp=email )
Change subject: LAPD: Add support for RTS based polling and T200 ...................................................................... Patch Set 8: Code-Review+1 (4 comments) File include/osmocom/isdn/lapd_core.h: https://gerrit.osmocom.org/c/libosmocore/+/34985/comment/096a5c7e_e9c0ff67 PS8, Line 88: #define LAPD_F_RTS 0x0001 (an enum would be nicer IMHO) File src/isdn/lapd_core.c: https://gerrit.osmocom.org/c/libosmocore/+/34985/comment/a08beb95_979c4df4 PS8, Line 220: Function to (just drop the words "Function to", rationale: it is obvious that it is a function) https://gerrit.osmocom.org/c/libosmocore/+/34985/comment/37864d12_f292a897 PS8, Line 400: \ref '\ref' is not valid doxygen here, see https://osmocom.org/projects/cellular-infrastructure/wiki/Guidelines_for_API_documentation#Parameters https://gerrit.osmocom.org/c/libosmocore/+/34985/comment/8dbf6784_2d0d40c0 PS8, Line 1785: Function call when a LAPD frame is ready to sent. this is hard to understand, could you make this an "imperative form" description of what the function does, like Send the next LAPD frame. (if that is correct). That is the shortest and clearest form of doc. thanks -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34985?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib961b5a44911b99b0487641533301749c0286995 Gerrit-Change-Number: 34985 Gerrit-PatchSet: 8 Gerrit-Owner: jolly <andr...@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Attention: jolly <andr...@eversberg.eu> Gerrit-Comment-Date: Wed, 22 Nov 2023 22:17:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
