Attention is currently required from: laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email )
Change subject: core: Add software UART implementation ...................................................................... Patch Set 4: (4 comments) Patchset: PS4: sorry, some late comments that were stranded in draft lands File include/osmocom/core/soft_uart.h: https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/160f09b8_e49e1896 PS3, Line 38: OSMO_SUART_F_BREAK = (1 << 2), (it is sometimes useful to define the bit positions instead of the bitmask. Like enum foo { FOO_ZERO = 0, FOO_ONE = 1, FOO_TWO = 2, }; and use it like if (flags & (1 << FOO_TWO)) ... (with a macro maybe) because that allows math on the bit position that i had to use once and can't remember now =) was it to iterate bits, or calculate used nr of bits...? Anyway, just saying, if FOO_FIVE == 0x10, it's not so trivial to calculate that back to a 5.) https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/e99d0176_e6532a56 PS3, Line 52: stop bots a stop bot, is that a traffic light? =) File src/core/soft_uart.c: https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/34735c3e_3114260e PS3, Line 4: * (C) 2022 by Harald Welte <lafo...@gnumonks.org> 2022-2023? (I'm slightly unclear, is this patch a collaboration of laforge and fixeria?) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2ca95963fd5852ddb89bdd35b86b31489127fe84 Gerrit-Change-Number: 30763 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <lafo...@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andr...@eversberg.eu> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: fixeria <vyanits...@sysmocom.de> Gerrit-CC: neels <nhofm...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Wed, 22 Nov 2023 23:16:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
