Attention is currently required from: pespin.

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/35176?usp=email )

Change subject: IuUP: Allow Initialization with set rem IP address and unset 
rem port
......................................................................


Patch Set 4:

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-mgw/+/35176/comment/4827b0ff_d321205f
PS2, Line 7: mgcp_network: Allow rx of IuUP in loopback mode with set rem IP 
address and unset rem port
> (you're getting into a habit of too long summary lines)
Done


Commit Message:

https://gerrit.osmocom.org/c/osmo-mgw/+/35176/comment/f1acf2a3_524febff
PS4, Line 7: rem
(i'd rather write out "remote" and abbreviate "Init" and "addr")


File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/35176/comment/22d2e586_68b0321b
PS2, Line 866: HACK: for IuUP, we want to reply with an IuUP Initialization ACK 
upon the first RTP
             :                   * messag
> Tests show these things: […]
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35176?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Idd833997abce46886e9664505b2776fa5dadc8db
Gerrit-Change-Number: 35176
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofm...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Dec 2023 23:47:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofm...@sysmocom.de>
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to